Skip to content

[Duplicate Expense] Allow bulk duplication. #84657

Merged
JS00001 merged 55 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/84281
Apr 9, 2026
Merged

[Duplicate Expense] Allow bulk duplication. #84657
JS00001 merged 55 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/84281

Conversation

@Krishna2323
Copy link
Copy Markdown
Contributor

@Krishna2323 Krishna2323 commented Mar 10, 2026

Explanation of Change

Fixed Issues

$ #84281
PROPOSAL:

Tests

  • Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

  1. Follow steps 1–3 from the QA Steps above to set up test data
  2. Turn off network (airplane mode or disconnect Wi-Fi)
  3. Select 2–3 cash expenses and click "Duplicate expense"
  4. Confirm duplicated expenses appear optimistically in the list while offline
  5. Turn the network back on
  6. Confirm the duplicated expenses persist after syncing with the server
  7. Confirm no duplicate or missing entries after reconnection

QA Steps

  1. Log in to the app
  2. Go to expense chat
  3. Create several test expenses:
    • At least 2 cash expenses (submitted by you)
    • At least 1 Per Diem expense with start & end dates
    • At least 1 Per Diem expense without start or end dates (if possible)
    • At least 1 Distance expense
    • At least 1 card expense (company card)
    • At least 1 expense with a receipt currently scanning
    • At least 1 expense on a report where you are not the submitter (e.g., as an approver/manager)
  4. Navigate to the Reports page → Expenses tab
  5. Verify option visibility (cash expenses):
    • Select a single cash expense (yours) → open the bulk actions menu
    • Confirm "Duplicate expense" option appears
    • Deselect all
  6. Verify option visibility (multiple cash expenses):
    • Select 2 or more cash expenses (yours) → open the bulk actions menu
    • Confirm "Duplicate expense" option appears
    • Deselect all
  7. Verify card expense exclusion:
    • Select only a card expense → open the bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  8. Verify mixed card + cash exclusion:
    • Select a cash expense AND a card expense together → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  9. Verify scanning expense exclusion:
    • Select an expense that is currently scanning → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  10. Verify mixed scanning + cash exclusion:
    • Select a cash expense AND a scanning expense together → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  11. Verify Per Diem without dates exclusion:
    • Select a Per Diem expense that has no start or end dates → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  12. Verify Per Diem with dates — allowed:
    • Select a Per Diem expense that has both start & end dates → open bulk actions menu
    • Confirm "Duplicate expense" DOES appear
    • Deselect all
  13. Verify non-submitter exclusion:
    • Select an expense from a report where you are NOT the submitter (e.g., you are the approver) → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  14. Verify mixed submitter + non-submitter exclusion:
    • Select one of your own expenses AND one from a report where you are not the submitter → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Deselect all
  15. Verify expense report tab exclusion:
    • Switch to the Reports tab
    • Select one or more reports → open bulk actions menu
    • Confirm "Duplicate expense" does NOT appear
    • Switch back to Expenses tab
  16. Verify distance expense — allowed:
    • Select a distance expense (yours) → open bulk actions menu
    • Confirm "Duplicate expense" DOES appear
    • Deselect all
  17. Verify mixed allowed types:
    • Select a cash expense, a Per Diem (with dates), and a distance expense together → open bulk actions menu
    • Confirm "Duplicate expense" DOES appear
    • Deselect all
  18. Verify bulk duplication works:
    • Select 2–3 cash expenses, note their amounts, merchants, and categories
    • Click "Duplicate expense"
    • Confirm the selection is cleared after clicking
    • Confirm new duplicated expenses appear in the list
    • Verify each duplicated expense has the correct amount, merchant, category, and currency
    • Verify the date on each duplicate is set to today
    • Verify receipt images are NOT copied to the duplicates
  19. Verify duplication works for Draft expenses
  20. Verify duplication works for Processing (submitted) expenses
  21. Verify duplication works for Approved expenses
  22. Verify duplication works for Paid/Reimbursed expenses
  23. Verify single duplicate still works:
    • Open a single expense from its report
    • Use the three-dot menu → "Duplicate"
    • Confirm the expense is duplicated correctly with the same fields
    • Verify the single-duplicate animation (icon changes to checkmark, text to "Duplicated", then reverts)
  24. Verify no regression on other bulk actions:
    • Confirm bulk Hold, Unhold, Delete, Approve, Pay actions still work as expected when selecting eligible expenses
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 10, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.65% <ø> (+3.17%) ⬆️
src/hooks/useBulkDuplicateAction.ts 100.00% <100.00%> (ø)
src/components/Search/SearchBulkActionsButton.tsx 2.56% <0.00%> (-0.07%) ⬇️
src/components/Search/BulkDuplicateHandler.tsx 0.00% <0.00%> (ø)
src/hooks/useSelectedTransactionsActions.ts 76.74% <80.95%> (-7.53%) ⬇️
src/hooks/useSearchBulkActions.ts 40.93% <87.03%> (+40.93%) ⬆️
...equestReportView/MoneyRequestReportActionsList.tsx 59.88% <37.93%> (-0.23%) ⬇️
src/components/MoneyReportHeader.tsx 0.00% <0.00%> (ø)
src/libs/actions/IOU/Duplicate.ts 88.03% <8.69%> (+88.03%) ⬆️
... and 271 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 marked this pull request as ready for review March 15, 2026 12:03
@Krishna2323 Krishna2323 requested review from a team as code owners March 15, 2026 12:03
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 15, 2026

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed request for a team March 15, 2026 12:03
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dca96c3007

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot melvin-bot bot requested a review from JS00001 April 9, 2026 17:17
@JS00001 JS00001 merged commit c522d11 into Expensify:main Apr 9, 2026
33 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 9, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.58-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

Yes, help site changes are required. PR #84657 adds bulk expense duplication, which contradicts the existing help article How-to-Duplicate-an-Expense.md — specifically the FAQ stating "No, you can't duplicate multiple expenses at once."

I've created a help site PR with the following changes:

#87569

  • Added a new "How to duplicate multiple expenses at once" section with step-by-step instructions
  • Updated the FAQ answer for "Can I duplicate multiple expenses at once?" from "No" to "Yes" with instructions
  • Updated article metadata (description, keywords, internalScope) to cover bulk duplication

No changes were needed to Expense-and-Report-Actions.md — the bulk duplicate action appears in the selection-mode bulk actions dropdown, not in the individual expense More menu documented in that article.

@mitarachim
Copy link
Copy Markdown

Deploy Blocker #87597 was identified to be related to this PR.

@nlemma
Copy link
Copy Markdown

nlemma commented Apr 10, 2026

Deploy Blocker #87599 was identified to be related to this PR.

@jponikarchuk
Copy link
Copy Markdown

Deploy Blocker #87598 was identified to be related to this PR.

@jponikarchuk
Copy link
Copy Markdown

Deploy Blocker #87604 was identified to be related to this PR.

@jponikarchuk
Copy link
Copy Markdown

Deploy Blocker #87609 was identified to be related to this PR.

@lanitochka17
Copy link
Copy Markdown

Deploy Blocker ##87634 was identified to be related to this PR

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.